[PATCH] D122372: [lld][COFF] Fix TypeServerSource lookup on GUID collisions
Tobias Hieta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 30 04:26:29 PDT 2022
thieta added a comment.
Ok after toying around with the code again I realize that you have a good point here @aganea - this simplified version is probably better and enough. You have to turn on verbose logging in lld to see the collisions, BUT they don't lead to anything bad anymore - so it's just for performance reasons you would like to see if it collides.
I also reduced the inputs to the test cases a bit.
How are feeling about this revision? Also @rnk - any input before this lands?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122372/new/
https://reviews.llvm.org/D122372
More information about the llvm-commits
mailing list