[PATCH] D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64.

Wed Mar 30 00:13:06 PDT 2022

jhenderson added a comment.

Nothing much else to add apart from a stylistic comment.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-extern-weak.ll:2-3
 ; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr4 \
-; RUN: -mattr=-altivec -data-sections=false -xcoff-traceback-table=false < %s | FileCheck --check-prefixes=COMMON,BIT32 %s
+; RUN: -mattr=-altivec -data-sections=false -xcoff-traceback-table=false < %s \
+; RUN:   | FileCheck --check-prefixes=COMMON,BIT32 %s

----------------
I have a personal preference for this syntax: from the first line, it makes it clear that the next line is a new command, whilst from the second line, the indentation followed by an executable name makes it clear that this is a continuation of the previous line.

Same applies elsewhere.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122287/new/

https://reviews.llvm.org/D122287