[PATCH] D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now).

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/MachO/stabs-sorted.yaml:231
+...
\ No newline at end of file

----------------
Nit: missing newline at EOF.


================
Comment at: llvm/test/tools/llvm-readobj/sort-symbols.test:1
+# Test that we print a warning for ELF, WASM, and COFF  but still dump the contents for all.
+
----------------
Double # for comments in these tests, and remove the double space.


================
Comment at: llvm/test/tools/llvm-readobj/sort-symbols.test:6
+# RUN: yaml2obj --docnum=3 %s -o %t_wasm
+# RUN: yaml2obj --docnum=4 %s -o %t_coff
+
----------------
Any particular reason you've not included xcoff?


================
Comment at: llvm/test/tools/llvm-readobj/sort-symbols.test:16
+# CHECK: Format: aixcoff-rs6000
+# CHECK-NOT: warning '{{.+}}_macho': --sort-symbols is not supported yet for this format.
+# CHECK: Format: Mach-O 64-bit x86-64
----------------
I'd consider pruning this back to just `warning '{{.+}}_macho':` to reduce the risk of false negatives due to a slight change in the warning message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116787/new/

https://reviews.llvm.org/D116787