[PATCH] D122558: [2/3] TLS loads optimization (hoist)
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 29 22:14:00 PDT 2022
xiangzhangllvm added a comment.
In D122558#3415640 <https://reviews.llvm.org/D122558#3415640>, @MaskRay wrote:
> If the option is going to be on and never turned off, we don't need a clang driver option. Clang driver option has a commitment to relative stability.
> For experimental things you can use `cl::opt`. `cl::opt` can be relatively freely removed.
Make sense, I prefer to keep the clang driver option for customers
(in fact, this job is required from our customers and they point out they want an option to control it)
Yes, I added `cl::opt` for it, PLS refer TLSVariableHoist.cpp: line 43.
Thanks a lot for your reviewing!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122558/new/
https://reviews.llvm.org/D122558
More information about the llvm-commits
mailing list