[PATCH] D122383: [Coroutines] [Retcon] Replace CoroBegin with FramePtr after

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

In D122383#3414748 <https://reviews.llvm.org/D122383#3414748>, @rjmccall wrote:

> Does that actually fix anything?  The problem is that the use-list of the frame pointer is being destroyed in the clones if it happens to be an argument of the ramp function.  We have to stop that from happening.  I don't see a solution to that other than either changing VMap or introducing an intermediate value so that it isn't just a use of an argument, and the former seems much easier.

I think the two strategies (Move the replacement of CoroBegin or set the memory argument for CoroBegin) aim to the solution `introducing an intermediate value so that it isn't just a use of an argument`, and the intermediate value here is the `llvm.coro.begin` itself. I think this one if more natural to changing VMap since it might be a noop for other coroutine ABIs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122383/new/

https://reviews.llvm.org/D122383