[PATCH] D122694: [MC][BOLT] Add setter for AllowAtInName
Maksim Panchenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 29 17:21:35 PDT 2022
maksfb added a comment.
In D122694#3415490 <https://reviews.llvm.org/D122694#3415490>, @efriedma wrote:
> If you look at LLVM itself, normally it refers to PLT entries using an MCSymbolRefExpr marked up with MCSymbolRefExpr::VK_PLT. Ideally, BOLT would do the same thing... but maybe not worth the effort. Symbols with an "@" sign shouldn't show up in practice on non-Windows targets.
Since BOLT operates on a post-link binary, it sees PLT entries created by the linker and marks them with "sym at PLT", i.e. there will be both - undefined "sym" and defined "sym at PLT". In theory, we can use VK_PLT, but on the surface it looks as it will create more problems for BOLT.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122694/new/
https://reviews.llvm.org/D122694
More information about the llvm-commits
mailing list