[PATCH] D116463: [SPIRV 4/6] Add target lowering, TargetMachine and AsmPrinter

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp:23
+  // Avoid fail on v3i1 argument. Maybe we need to return 1 for all types.
+  if (VT.isVector() && VT.getVectorNumElements() == 3 &&
+      (VT.getVectorElementType() == MVT::i1 ||
----------------
iliya-diyachkov wrote:
> arsenm wrote:
> > Do you need either of these hacks anymore? The support for odd sized vectors has improved in recent years
> It's still needed, otherwise CallLowering fails inside getVectorTypeBreakdown on some tests which passes/returns <3 x i1> vectors. Once it's supported by default code, we'll remove this hacks.
Then seems a good use of TODO or FIXME


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116463/new/

https://reviews.llvm.org/D116463