[PATCH] D121623: [LV] Remove unneeded createHeaderBranch.(NFCI)
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 29 12:35:33 PDT 2022
Ayal added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7590
ILV.createVectorizedLoopSkeleton();
+ State.CFG.LastBB = ILV.LoopMiddleBlock;
ILV.collectPoisonGeneratingRecipes(State);
----------------
fhahn wrote:
> Ayal wrote:
> > Would be good to set here the minimal fields of State needed, PrevBB/VectorLoopPreHeader being an anchor, and complement other caching fields later - possibly LastBB included?
> I tried to move all revenant initializations here.
Oh, no, sorry ... I meant LVP should (continue to) set the minimal amount of fields in State here, and let VPlan complement whatever additional fields it needs later, as done now. Wanted to make sure if ExitBB needs to be set to middleBlock here, instead of setting it later to L->getExitBlock() in VPlan::execute() as done now, say because the creation of L is to be moved to later?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121623/new/
https://reviews.llvm.org/D121623
More information about the llvm-commits
mailing list