[PATCH] D122251: [lit] Use sharding for GoogleTest format

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

In D122251#3414630 <https://reviews.llvm.org/D122251#3414630>, @rnk wrote:

> I don't have time to review the code, but this seems like a good direction.
>
> What happens if the unit test shard crashes without writing the final JSON file? Does lit handle that? Is or can it be tested, and if not, what gives you confidence that it will work?

It would trigger an assertion failure :  `assert os.path.exists(test.gtest_json_file)`. The only way this could happen is the copy of GoogleTest in LLVM has crashing bugs that may be triggered by new tests or new test environments (existing ones, if any, should be found when this patch is landed). I think both cases could be detected and handled reliably.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251