[PATCH] D122251: [lit] Use sharding for GoogleTest format

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added subscribers: mstorsjo, rnk, compnerd.
ychen added a comment.

In D122251#3407354 <https://reviews.llvm.org/D122251#3407354>, @jhenderson wrote:

> My knowledge of this area is relatively limited, so I don't feel like I have a good enough understanding of the intricacies to progress this review further. Thanks for the explanations as to why this approach is most appropriate. The real cost sounds like it's due to process spawning overhead primarily (and any startup costs within the program itself). That does make me wonder whether there's a natural way of threading things within the test programs themselves, but I suspect not as I doubt the unit tests are thread-safe. Consequently, this approach seems sound, but hopefully others with knowledge in this area might be able to chime in?

@jhenderson Thanks for taking a look. Adding a few potentially interested reviewers working on Windows (@rnk, @mstorsjo, @compnerd).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251