[PATCH] D122482: [X86] combineADC - fold ADC(C1,C2,Carry) -> ADC(0,C1+C2,Carry)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

any further comments?



================
Comment at: llvm/test/CodeGen/X86/combine-adc.ll:88
 ; X64-NEXT:    addb $-1, %dil
-; X64-NEXT:    movl $55, %eax
-; X64-NEXT:    adcl $-1, %eax
+; X64-NEXT:    adcl $54, %eax
 ; X64-NEXT:    retq
----------------
RKSimon wrote:
> craig.topper wrote:
> > This still seems more complicated that it needs to be.
> Yes combineCarryThroughADD is missing a fold to X86ISD::BT, its on my todo list.......
This is addressed in D122572 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122482/new/

https://reviews.llvm.org/D122482