[PATCH] D69562: Mapping of FP operations to constrained intrinsics

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor accepted this revision.
andrew.w.kaylor added a comment.
This revision is now accepted and ready to land.

This looks good. I have just a couple of minor nits.



================
Comment at: llvm/include/llvm/IR/FPEnv.h:71
+/// strictfp function. If the instruction is already a constrained intrinsic or
+/// does not constrained intrinsic counterpart, the function returns zero.
+Intrinsic::ID getConstrainedIntrinsicID(const Instruction &Instr);
----------------



================
Comment at: llvm/lib/IR/FPEnv.cpp:92
+  switch (Instr.getOpcode()) {
+  case Instruction::FCmp:
+    IID = Intrinsic::experimental_constrained_fcmp;
----------------
It may be worth having a comment here to explain why FCmp is handled separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69562/new/

https://reviews.llvm.org/D69562