[PATCH] D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now).

Tue Mar 29 08:45:21 PDT 2022

oontvoo marked an inline comment as done.
oontvoo added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/MachO/stabs-sorted.yaml:12-14
+## Test that we print a warning for ELF but still dump the contents for both.
+# RUN: yaml2obj --docnum=2 %s -o %t_elf
+# RUN: llvm-readobj --syms --sort-symbols=type,name %t_elf %t 2>&1 | FileCheck %s --check-prefix WARN
----------------
jhenderson wrote:
> oontvoo wrote:
> > jhenderson wrote:
> > > As this logic is testing generic logic in the tool, rather than format-specific logic, I think you'd be better off pulling it into a separate test directly in the llvm-readobj directory. Additionally, I wouldn't use ELF, as ELF is a good candidate for the next format to support. I'd use one of the other input formats supported by llvm-readobj.
> > As you've said, this test is temporary until the other formats are implemented. As such, I dont see why it needs to go out in a separate test file
> As an ELF developer, I wouldn't necessarily expect me adding support to the ELF layer to break a Mach-O test, which is currently what would happen.
k

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116787/new/

https://reviews.llvm.org/D116787