[PATCH] D122594: [ArgPromotion] Update min-legal-vector-width when do promotion

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 07:32:38 PDT 2022


pengfei added a comment.

In D122594#3411792 <https://reviews.llvm.org/D122594#3411792>, @craig.topper wrote:

> Isn't X86TTIImpl::areTypesABICompatible supposed to be preventing promotion when it was cause a mismatch?

It doesn't work in complicated situations, e.g.: https://godbolt.org/z/386n6ErcY
On the other hand, I think it makes sense to always update `min-legal-vector-width` to the largest vector width.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122594/new/

https://reviews.llvm.org/D122594



More information about the llvm-commits mailing list