[PATCH] D122639: [CMake] Keep targets in folder in Visual Studio

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

FWIW, I think this looks reasonable -- however, I think there are missing changes elsewhere. When I search for `set_target_properties.*FOLDER.*` across the entire monorepo, I get 197 hits many of which are not touched here. Should we be hitting all of the folders instead of just a subset of them?

Also, given how easy it would be to forget this when adding a new folder in the future, I sort of wonder whether we want to make a CMake macro for setting a folder so that we can capture the logic in one place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122639/new/

https://reviews.llvm.org/D122639