[PATCH] D121355: [SelectionDAG] Fold shift constants into cmp

[Allen zhong via Phabricator via llvm-commits]

Allen marked an inline comment as done.
Allen added a comment.

In D121355#3413414 <https://reviews.llvm.org/D121355#3413414>, @RKSimon wrote:

> I'm a little worried that this is likely to lead to infinite loops with constant/condcode combines fighting - this feels like it should be be backend specific tbh, or maybe even ISelDAGToDAG.

I added condition isLegalICmpImmediate on line 4335, which will guard the infinite loops.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121355/new/

https://reviews.llvm.org/D121355