[PATCH] D122540: [X86] Fix handling of maskmovdqu in x32 differently
Harald van Dijk via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 28 23:26:57 PDT 2022
hvdijk added a comment.
In D122540#3412980 <https://reviews.llvm.org/D122540#3412980>, @skan wrote:
> I believe you can come up this patch independently. But I did make some suggestion about potential solutions in D103427 <https://reviews.llvm.org/D103427> and prove it in D122537 <https://reviews.llvm.org/D122537>. Would you mind adding me as the co-author and reviewer?
The idea to reuse MASKMOVDQU and VMASKMOVDQU did come from you, the summary should mention that, sure. Edited, I hope that looks okay to you.
And anyone is always welcome to add themself as a reviewer, please feel free to. I would prefer someone else who was completely uninvolved with the implementation to review this as well though, in case there is something we both missed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122540/new/
https://reviews.llvm.org/D122540
More information about the llvm-commits
mailing list