[PATCH] D122372: [lld][COFF] Fix TypeServerSource lookup on GUID collisions

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

In D122372#3413032 <https://reviews.llvm.org/D122372#3413032>, @aganea wrote:

> Reduced further:
>
>   > yaml2obj.exe -o=a.obj lld\test\COFF\Inputs\pdb-type-server-simple-a.yaml
>   > sed -e s/ts.pdb/bs.pdb/ lld\test\COFF\Inputs\pdb-type-server-simple-b.yaml | yaml2obj.exe > b.obj
>   > llvm-pdbutil.exe yaml2pdb lld\test\COFF\Inputs\pdb-type-server-simple-ts.yaml -pdb ts.pdb
>   > llvm-pdbutil.exe yaml2pdb lld\test\COFF\Inputs\pdb-type-server-simple-ts.yaml -pdb bs.pdb
>   > lld-link.exe a.obj b.obj /debug
>   (crash)

The crash is just part of the problem here - the crash is because of the assertion. If you build without asserts - you don't get a crash instead you get mixed up debug information where the symbols get the wrong type. That's why the actual check is looking to confirm that the type matches the source.

That said - I think I don't need to add both inputs since I can use sed to change the invalid guid to the valid one between test cases. I'll update with that later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122372/new/

https://reviews.llvm.org/D122372