[PATCH] D122459: [ELF] Fix relocations against .eh_frame

[Haowei Wu via Phabricator via llvm-commits]

haowei added subscribers: leonardchan, haowei.
haowei added a comment.

Hi, we are seeing build failures in our clang bots in `Performing build step for 'runtimes-x86_64-unknown-linux-gnu'` after this change lands, error message:

  [533/1404] Linking CXX shared library /b/s/w/ir/x/w/staging/llvm_build/lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_minimal.so
  FAILED: /b/s/w/ir/x/w/staging/llvm_build/lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_minimal.so 
  : && /b/s/w/ir/x/w/staging/llvm_build/./bin/clang++ --target=x86_64-unknown-linux-gnu --sysroot=/b/s/w/ir/x/w/cipd/linux -fPIC --target=x86_64-unknown-linux-gnu -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -ffile-prefix-map=/b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-linux-gnu-bins=../staging/llvm_build/runtimes/runtimes-x86_64-unknown-linux-gnu-bins -ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -Wall -std=c++14 -Wno-unused-parameter -O2 -g -DNDEBUG  -fuse-ld=lld  -Wl,-z,nodelete -fuse-ld=lld -Wl,--color-diagnostics   -nodefaultlibs -Wl,-z,text -nostdlib++ -shared -Wl,-soname,libclang_rt.ubsan_minimal.so -o /b/s/w/ir/x/w/staging/llvm_build/lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_minimal.so compiler-rt/lib/ubsan_minimal/CMakeFiles/RTUbsan_minimal.x86_64.dir/ubsan_minimal_handlers.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/b/s/w/ir/x/w/staging/llvm_build/./lib"  -lc  /b/s/w/ir/x/w/staging/llvm_build/lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.builtins.a && :
  ld.lld: error: /b/s/w/ir/x/w/staging/llvm_build/./lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/clang_rt.crtbegin.o:(.eh_frame): offset is outside the section
  ld.lld: error: /b/s/w/ir/x/w/staging/llvm_build/./lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/clang_rt.crtbegin.o:(.eh_frame): offset is outside the section
  clang++: error: linker command failed with exit code 1 (use -v to see invocation)

We reproduced this issue by building revision `6faba31e0d88ce71e87567ddb51d2444524b8a81` on the same bot and it failed with the same error message: https://luci-milo.appspot.com/raw/build/logs.chromium.org/fuchsia/led/haowei_google.com/187f5403ad43469ef5de98fe44ea4170eb453eaedf1b0bda309062d30a114113/+/build.proto The same build passed on f7381a795ab235d34c94eaf01dc880eb5b89619d <https://reviews.llvm.org/rGf7381a795ab235d34c94eaf01dc880eb5b89619d> which is one patch ahead.

Could you take a look? If it takes some time to fix forward, could you revert this change first please? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122459/new/

https://reviews.llvm.org/D122459