[PATCH] D122624: [lld/mac] Give range extension thunks for local symbols local visibility

Mon Mar 28 17:57:37 PDT 2022

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

Nice!

Can you include a bit more info in the commit message? Would be nice if people didn't have to click through to the PR

================
Comment at: lld/MachO/ConcatOutputSection.cpp:92-93
 //
-// * A thunk incarnation comprises (a) private-extern Defined symbol pointing
-//   to (b) an InputSection holding machine instructions (similar to a MachO
+// * A thunk consists of (a) a Defined symbol pointing to
+//   (b) an InputSection holding machine instructions (similar to a MachO
 //   stub), and (c) Reloc(s) that reference the real function for fixing-up
----------------
nit: reflow paragraph?

================
Comment at: lld/test/MachO/arm64-thunk-visibility.s:4
+# foo.s and bar.s both contain TU-local symbols (think static function)
+# with the same name, and both need a thunk..  This tests that ld64.lld doesn't
+# create a duplicate symbol for the two functions.
----------------
ultra nit: not sure if you intended to use one dot or three :p

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122624/new/

https://reviews.llvm.org/D122624