[PATCH] D116952: [ConstantFolding] Respect denormal handling mode attributes when folding instructions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 17:54:39 PDT 2022


efriedma added a comment.

ConstantFoldBinaryOpOperands has other callers; are you planning to fix each of them separately?

Assuming IEEE denormal handling if we can't find the parent Function seems a bit dubious, but maybe it's the best we can do for now.  It's not clear to me how this interacts with floating-point constant expressions (e.g. ConstantExpr::getFAdd).  I guess we could just kill off floating-point constant expressions, since they aren't really useful in practice, but that's a non-trivial effort.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116952/new/

https://reviews.llvm.org/D116952



More information about the llvm-commits mailing list