[PATCH] D118441: Preserve aliasing info during memory intrinsics lowering

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 16:08:56 PDT 2022


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.

LGTM but a lit test would be much more maintainable



================
Comment at: llvm/unittests/Transforms/Utils/MemTransferLowering.cpp:173
         auto *TargetBB = getBasicBlockByName(F, "vector.body");
-        EXPECT_NONFATAL_FAILURE(EXPECT_NE(TargetBB, nullptr), "");
+        EXPECT_NE(TargetBB, nullptr);
         return PreservedAnalyses::all();
----------------
These operands should be swapped to get correct error messages


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118441/new/

https://reviews.llvm.org/D118441



More information about the llvm-commits mailing list