[PATCH] D118440: New regression test against expandMemCpyAsLoop utility

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 16:07:35 PDT 2022


arsenm added inline comments.
Herald added a project: All.


================
Comment at: llvm/unittests/Transforms/Utils/MemTransferLowering.cpp:64
+  BasicBlock *getBasicBlockByName(Function &F, StringRef Name) const {
+    for (BasicBlock &BB : F)
+      if (BB.getName() == Name)
----------------
Braces


================
Comment at: llvm/unittests/Transforms/Utils/MemTransferLowering.cpp:166-167
+        Instruction *Inst = &MemCpyBB->front();
+        assert(isa<MemCpyInst>(Inst) &&
+               "Expecting llvm.memcpy.p0i8.i64 instructon");
+        MemCpyInst *MemCpyI = cast<MemCpyInst>(Inst);
----------------
This is redundant with the cast<>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118440/new/

https://reviews.llvm.org/D118440



More information about the llvm-commits mailing list