[PATCH] D122100: [BOLT] AArch64: Read all static relocations

Mon Mar 28 15:41:01 PDT 2022

yota9 added a comment.

> Can you give more details on what is broken when only the dynamic relocation is consumed?

>From the runtime standpoint nothing is broken, since we update dynamic relocations and at runtime the memory value would be right. I just don't see any reason for aarch64 to skip the static relocations currently.  Also the D122106 <https://reviews.llvm.org/D122106> needs this patch so both static and dynamic relocs would be available.

> I'm also eager for the aarch64 tests to be enabled on x86 as well,

I'm trying to write cross-platform tests when possible. As for X86 - the condition to skip static relocs was added on purpose, according to @maksfb commit message it was done because "BOLT fails
to validate the extracted value at the address.".  We validate values only for x86 currently, so this problem does not affect aarch64 platform. I think it is out of scope of this review to fix x86 platform too :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122100/new/

https://reviews.llvm.org/D122100