[PATCH] D122616: RegAlloc: Fix verifier error after failed allocation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: qcolombet, MatzeB.
Herald added subscribers: kerbowa, hiraditya, jvesely.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

In some cases after reporting an allocation failure, this would fail
the verifier. It picks the first allocatable register and assigns it,
but didn't update the liveness appropriately. When VirtRegRewriter
relied on the liveness to set kill flags, it would incorrectly add
kill flags if there was another overlapping kill of the virtual
register.

      

We can't properly assign the register to an overlapping range, so
break the liveness of the failing register (and any other interfering
registers) instead. Give the virtual register dummy liveness by
effectively deleting all the uses by setting them to undef.

      

The edge case not tested here which I'm worried about is if the read
of the register is a def of a subregister. I've been unable to come up
with a test where this occurs.


https://reviews.llvm.org/D122616

Files:
  llvm/lib/CodeGen/RegAllocBase.cpp
  llvm/lib/CodeGen/RegAllocBase.h
  llvm/lib/CodeGen/RegAllocBasic.cpp
  llvm/lib/CodeGen/RegAllocGreedy.cpp
  llvm/test/CodeGen/AMDGPU/issue48473.mir
  llvm/test/CodeGen/AMDGPU/regalloc-failure-overlapping-insert-assert.mir
  llvm/test/CodeGen/AMDGPU/register-killed-error-after-alloc-failure0.mir
  llvm/test/CodeGen/AMDGPU/register-killed-error-after-alloc-failure1.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122616.418702.patch
Type: text/x-patch
Size: 13369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220328/50cb48dc/attachment.bin>