[PATCH] D116463: [SPIRV 4/6] Add target lowering, TargetMachine and AsmPrinter

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 14:02:15 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:89
+                                  CallLoweringInfo &Info) const {
+  assert(Info.OrigRet.Regs.size() < 2 && "Call returns multiple vregs");
+
----------------
iliya-diyachkov wrote:
> arsenm wrote:
> > Struct returns
> Explained above.
It's still valid IR, so should do better than assert. Return false to fail cleanly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116463/new/

https://reviews.llvm.org/D116463



More information about the llvm-commits mailing list