[PATCH] D120905: [demangler] Add operator precedence

[Frederik Gossen via Phabricator via llvm-commits]

frgossen added inline comments.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:1785
 
   template<typename Fn> void match(Fn F) const { F(LHS, InfixOperator, RHS); }
 
----------------
ldionne wrote:
> goncharov wrote:
> > I am not familiar with the code at all, but it seems to be an issue. We have downstream code that relies on the ability to match mode from ctor, but this "match" and other definitions have not been updated along with ctors. Do you mind reverting the patch for now?
> > 
> Can you give a bit more context regarding what issue you're encountering? Since this was landed some time ago, I think it would be best to fix-forward if we can.
We have a use of `match` that expects to invoke the constructor with the arguments it's being passed. That use is missing the precedence argument now, which is not being passed here but it is required for the constructor above. 

I am not sure if this is a false use of `match` or if the `match` function should deal with the prec argument also. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120905/new/

https://reviews.llvm.org/D120905