[PATCH] D122521: Value-number GVNHoist loads by result type as well as pointer address.

[Joshua Cranmer via Phabricator via llvm-commits]

jcranmer-intel added a comment.

One minor change, but otherwise LGTM



================
Comment at: llvm/lib/Transforms/Scalar/GVNHoist.cpp:162
 // VNtoInsns.
-enum : unsigned { InvalidVN = ~2U };
+enum : uintptr_t { InvalidVN = (uintptr_t)~2 };
 
----------------
You'll want to transpose the `~` and the `(uintptr_t)` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122521/new/

https://reviews.llvm.org/D122521