[PATCH] D122610: [SDAG] avoid libcalls to fmin/fmax for soft-float targets

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 12:37:16 PDT 2022


spatel created this revision.
spatel added reviewers: irichter, efriedma, craig.topper, uweigand.
Herald added subscribers: StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, mcrosier.
Herald added a project: All.
spatel requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, MaskRay.
Herald added a project: LLVM.

This is an extension of D70965 <https://reviews.llvm.org/D70965> to avoid creating a mathlib call where it did not exist in the original source. Also see D70852 <https://reviews.llvm.org/D70852> for discussion about an alternative proposal that was abandoned.

In the motivating bug report:
https://github.com/llvm/llvm-project/issues/54554
...we also have a more general issue about handling "no-builtin" options. I'm not sure how that works yet.


https://reviews.llvm.org/D122610

Files:
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/test/CodeGen/ARM/vecreduce-fmax-legalization-soft-float.ll
  llvm/test/CodeGen/ARM/vecreduce-fmin-legalization-soft-float.ll
  llvm/test/CodeGen/RISCV/fmax-fmin.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122610.418675.patch
Type: text/x-patch
Size: 27982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220328/2f545a5d/attachment.bin>


More information about the llvm-commits mailing list