[PATCH] D122606: [demangler][NFC] Rename SwapAndRestore to DynamicOverride

[Nathan Sidwell via Phabricator via llvm-commits]

urnathan created this revision.
urnathan added reviewers: bruno, dblaikie, erichkeane.
Herald added a subscriber: hiraditya.
Herald added a project: All.
urnathan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The demangler has a utility class 'SwapAndRestore'. That name is confusing. It's not swapping anything, and the restore part happens at the object's destruction. What it's actually doing is allowing a override of some value that is dynamically accessible within the lifetime of a lexical scope. A better name, IMHO, is DynamicOverride, and a rename of its member variables.


https://reviews.llvm.org/D122606

Files:
  libcxxabi/src/demangle/ItaniumDemangle.h
  libcxxabi/src/demangle/Utility.h
  llvm/include/llvm/Demangle/ItaniumDemangle.h
  llvm/include/llvm/Demangle/Utility.h
  llvm/lib/Demangle/RustDemangle.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122606.418666.patch
Type: text/x-patch
Size: 18534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220328/fc036108/attachment-0001.bin>