[PATCH] D120905: [demangler] Add operator precedence

Mikhail Goncharov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 10:33:13 PDT 2022


goncharov added inline comments.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:1785
 
   template<typename Fn> void match(Fn F) const { F(LHS, InfixOperator, RHS); }
 
----------------
I am not familiar with the code at all, but it seems to be an issue. We have downstream code that relies on the ability to match mode from ctor, but this "match" and other definitions have not been updated along with ctors. Do you mind reverting the patch for now?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120905/new/

https://reviews.llvm.org/D120905



More information about the llvm-commits mailing list