[PATCH] D121008: [MicroBenchmarks] Add benchmarks for vector memory check generation.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 09:38:36 PDT 2022


fhahn updated this revision to Diff 418621.
fhahn added a comment.

In D121008#3405514 <https://reviews.llvm.org/D121008#3405514>, @Meinersbur wrote:

> Sorry for the delay.
>
> I doesn't seem to be important that `TC` is a compile-time constant, so I would have uses BENCHMARK(..)->Arg <https://github.com/google/benchmark/blob/main/docs/user_guide.md#passing-arguments> instead of BENCHMARK_TEMPLATE. It's also not important.
>
> LGTM

Thanks! I updated the code to use `BENCHMARK(...)->Arg()` instead. I am planning to land it soon.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121008/new/

https://reviews.llvm.org/D121008

Files:
  MicroBenchmarks/LoopVectorization/CMakeLists.txt
  MicroBenchmarks/LoopVectorization/RuntimeChecks.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121008.418621.patch
Type: text/x-patch
Size: 4889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220328/b6305313/attachment.bin>


More information about the llvm-commits mailing list