[PATCH] D122372: [lld][COFF] Fix TypeServerSource lookup on GUID collisions
Tobias Hieta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 28 08:02:19 PDT 2022
thieta marked an inline comment as done.
thieta added a comment.
@rnk thanks for your suggestions - I was almost there, but got hung up on trying to replicate the warning message and check for that instead of inspecting the actual contents. That was much easier.
I also added a test case for the duplicate-but-valid Guid case, and commited a small fix for that case as well so that it passes.
The inputs are a bit big - but I am unsure on how to trim them down efficiently.
Otherwise I think this is ready to land.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122372/new/
https://reviews.llvm.org/D122372
More information about the llvm-commits
mailing list