[PATCH] D122562: [NVPTX] Fix poorly designed assertion introduced in D120129

Daniil Kovalev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 07:40:18 PDT 2022


kovdan01 added a comment.

@jdoerfert Merged, hope your CI will be fixed. Could you please change "Changes requested" mark in D120129 <https://reviews.llvm.org/D120129> when you verify that everything is OK? Just to make that revision closed again.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:4266
+
+  assert(!isKernelFunction(*F));
+  return Align(std::max(uint64_t(16), ABITypeAlign));
----------------
jdoerfert wrote:
> Add some text, `&& "Expected kernels to have external linkage")`, or similar.
Ah, forgot that, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122562/new/

https://reviews.llvm.org/D122562



More information about the llvm-commits mailing list