[PATCH] D122562: [NVPTX] Fix poorly designed assertion introduced in D120129

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 07:18:21 PDT 2022


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, one nit.

(Also much cleaner, thanks)



================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:4266
+
+  assert(!isKernelFunction(*F));
+  return Align(std::max(uint64_t(16), ABITypeAlign));
----------------
Add some text, `&& "Expected kernels to have external linkage")`, or similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122562/new/

https://reviews.llvm.org/D122562



More information about the llvm-commits mailing list