[PATCH] D122580: RegAllocGreedy: Roll back successful recolorings on failure

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

Comments on the RISC-V test to keep it consistent with all the others



================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv64-unknown-linux-gnu < %s | FileCheck %s
+
----------------
Use just -mtriple=riscv64


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:10
+
+define void @main() #0 {
+; CHECK-LABEL: main:
----------------
Call it something other than main?


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:100-105
+
+attributes #0 = { "target-features"="+64bit,+a,+c,+d,+f,+m,+relax,+zfh,+zve32f,+zve32x,+zve64f,+zve64x,+zvl128b,+zvl256b,+zvl32b,+zvl64b,-save-restore,+experimental-zvfh" }
+attributes #1 = { nounwind readonly }
+attributes #2 = { nounwind readnone }
+attributes #3 = { nounwind }
+attributes #4 = { nounwind writeonly }
----------------
Don't need any of these (target-features should be in llc's mattr command line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122580/new/

https://reviews.llvm.org/D122580