[PATCH] D122274: [AArch64] Fix AArch64TargetParser.def to match AArch64.td.

[Tomas Matheson via Phabricator via llvm-commits]

tmatheson accepted this revision.
tmatheson added a comment.

LGTM, just some comments/notes on what changes for others looking at this.



================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:193
                  (AArch64::AEK_FP16 | AArch64::AEK_DOTPROD | AArch64::AEK_RCPC |
-                  AArch64::AEK_SSBS))
+                  AArch64::AEK_SSBS | AArch64::AEK_PROFILE))
 AARCH64_CPU_NAME("cortex-a78c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
----------------
Adds +spe. The processor supports it.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:197
+                  AArch64::AEK_SSBS | AArch64::AEK_PROFILE | AArch64::AEK_FLAGM |
+                  AArch64::AEK_PAUTH | AArch64::AEK_FP16FML))
 AARCH64_CPU_NAME("cortex-a710", ARMV9A, FK_NEON_FP_ARMV8, false,
----------------
Adds +spe,+flagm,+pauth,+fp16fml to target features. Discussion on D93022 seems to support them.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:210
                  (AArch64::AEK_FP16 | AArch64::AEK_DOTPROD | AArch64::AEK_RCPC |
-                  AArch64::AEK_SSBS | AArch64::AEK_PAUTH))
+                  AArch64::AEK_SSBS | AArch64::AEK_PAUTH | AArch64::AEK_PROFILE))
 AARCH64_CPU_NAME("cortex-x2", ARMV9A, FK_NEON_FP_ARMV8, false,
----------------
Adds +spe (same for x1)


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:232
+                  AArch64::AEK_DOTPROD | AArch64::AEK_PROFILE |
+                  AArch64::AEK_RAND | AArch64::AEK_FP16FML | AArch64::AEK_I8MM))
 AARCH64_CPU_NAME("neoverse-v1", ARMV8_4A, FK_CRYPTO_NEON_FP_ARMV8, false,
----------------
Adds +spe,+rand,+i8mm

+fp16fml is not required because +fp16 implies +fp16fml for v8.4 (D50229)




================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:234
-                  AArch64::AEK_RCPC | AArch64::AEK_FP16 | AArch64::AEK_BF16 |
-                  AArch64::AEK_DOTPROD ))
 AARCH64_CPU_NAME("cyclone", ARMV8A, FK_CRYPTO_NEON_FP_ARMV8, false,
----------------
RCPC/RAS implied by 8.4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122274/new/

https://reviews.llvm.org/D122274