[PATCH] D122489: [AMDGPU] Fix adding modifiers when creating v_cmpx instructions.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 04:06:56 PDT 2022


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:457
+    if (auto *Mod = TII->getNamedOperand(VCmp, OperandName))
+      Builder.addImm(Mod->getImm());
+  };
----------------
I think you might be able to simplify this to `Builder.add(*Mod)` but I'm not sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122489/new/

https://reviews.llvm.org/D122489



More information about the llvm-commits mailing list