[PATCH] D122530: [demangler] Support C23 _BitInt type

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 04:05:45 PDT 2022


aaron.ballman added a comment.

In D122530#3410157 <https://reviews.llvm.org/D122530#3410157>, @zsrkmyn wrote:

> In D122530#3410074 <https://reviews.llvm.org/D122530#3410074>, @aaron.ballman wrote:
>
>> Thank you for this! It looks correct to me, but the changes should probably come with some test coverage as well.
>
> There are actually some tests in libcxxabi/test/test_demangle.pass.cpp, but since the file is too large, phab folds it as a binary file :-(

Oh wow, I've never seen that happen before, thanks for letting me know!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122530/new/

https://reviews.llvm.org/D122530



More information about the llvm-commits mailing list