[PATCH] D122557: [NFC][CodeGen] Add a setTargetDAGCombine use initializer_list

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 01:38:00 PDT 2022


frasercrmck added a comment.

Nothing against it in principle, but might it be better to have it take an `ArrayRef` instead? Then people can use this in other ways, e.g., an array or dynamically constructing a `SmallVector`. Also I think it'd be good if other targets were changed to use this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122557/new/

https://reviews.llvm.org/D122557



More information about the llvm-commits mailing list