[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 01:36:36 PDT 2022


MaskRay added a comment.

The original patch added 600 lines while the subject just said "Move". This may be fishy as well.

Having TableGen related `void RVVIntrinsic::emitCodeGenSwitchBody(raw_ostream &OS) const {` in LLVMSupport is also weird.

So I think this patch deserves more discussion and should not be simply reapplied.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121984/new/

https://reviews.llvm.org/D121984



More information about the llvm-commits mailing list