[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 01:07:22 PDT 2022


MaskRay added a comment.

Seems that there is a circular dependency problem: 7c7e7770b7176f452d40f4e7ac545aaee1b19c4d <https://reviews.llvm.org/rG7c7e7770b7176f452d40f4e7ac545aaee1b19c4d> (reverted).

I'd suggest that we revert this patch.

Having target specific stuff in LLVMSupport is always fishy. 
Yes, we have ARMAttributeParser.h, ARMBuildAttributes.h, then we have more RISCV* headers.
I can kinda understand it because clang-tblgen only depends on LLVMSupport.
But this circular dependency requires more thoughts, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121984/new/

https://reviews.llvm.org/D121984



More information about the llvm-commits mailing list