[PATCH] D122113: [X86] Simplify the interface to getCondNoFromDesc.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 20 22:07:20 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:2606
-  return static_cast<X86::CondCode>(
-      MI.getOperand(static_cast<unsigned>(CondNo)).getImm());
 }
----------------
skan wrote:
> Did you get an warning from compiler when removing this `static_cast`?
I didn't get any warning and this isn't the only place in tree we pass int to getOperand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122113/new/

https://reviews.llvm.org/D122113



More information about the llvm-commits mailing list