[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2
Dávid Bolvanský via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 20 01:55:34 PDT 2022
xbolva00 added inline comments.
================
Comment at: llvm/test/Transforms/InstCombine/ispow2.ll:538
; Negative test - wrong predicate (but this could reduce).
----------------
hkmatsumoto wrote:
> xbolva00 wrote:
> > Now reduced.
> Since this is almost the first time contributing to LLVM, I'm not sure what I should do about this. Does it mean we should remove these reduced tests?
just remove "(but this could reduce)" from the comment I think.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122077/new/
https://reviews.llvm.org/D122077
More information about the llvm-commits
mailing list