[PATCH] D122079: [ADT] Add Enum matcher

Pete Cooper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 19 18:07:14 PDT 2022


pete accepted this revision.
pete added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/ADT/EnumMatcher.h:10
+// This magic blob of code here looks awful, but it is actually pretty clever.
+// If you call isValidForDXIL with a constant value, this should generate an
+// insane AST that will all constant fold down to true or false.
----------------
Probably shouldn’t have DXIL in the comment. Otherwise LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122079/new/

https://reviews.llvm.org/D122079



More information about the llvm-commits mailing list