[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 19 17:37:03 PDT 2022


beanz added a comment.

In D122082#3394525 <https://reviews.llvm.org/D122082#3394525>, @nikic wrote:

> This implementation is not compatible with opaque pointers (https://llvm.org/docs/OpaquePointers.html) and will likely need a significant rework to support them.

I don’t disagree, but…

Much of this code will work just fine with opaque pointers, and opaque pointers aren’t fully supported in clang (the only frontend we’re trying to support).

Since this code is going into an experimental backend, does opaque pointer support need to block this from landing, or can that be addressed subsequently?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082



More information about the llvm-commits mailing list