[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 19 05:00:42 PDT 2022


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1246
+  // few operations
+  if (Imm >= 63) {
+    if (!DstIsKill) {
----------------
I suggest we make another patch for merge `AVRRelaxMem::relax<AVR::STDWPtrQRr>` into `expand<AVR::STDWPtrQRr>`, for the case `Imm >= 63`. And we select that merge patch as baseline / parent of current patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114611/new/

https://reviews.llvm.org/D114611



More information about the llvm-commits mailing list