[PATCH] D121727: [NVPTX] Integrate ptxas to LIT tests
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 18 14:17:33 PDT 2022
jdenny added a comment.
In D121727#3393335 <https://reviews.llvm.org/D121727#3393335>, @jhenderson wrote:
> Of course, this above has a lot of duplicated code, so it might be nice to make the if an if/else ternary-style. Spitball idea:
>
> RUN: ... | FileCheck %s --check-prefix={%if windows {WINDOWS} else {NON-WINDOWS}}
I like this direction as it seems more flexible. Why do we need the outermost braces?
> Bonus points would allow this if to span multiple lines. Maybe this:
>
> RUN: {%if feature { \
> RUN: command1; \
> RUN: command2 | \
> RUN: command3}}
Might be nice if the `\` is not required so it's possible to enclose multiple existing RUN lines without having to join them with `;`, `&&`, etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121727/new/
https://reviews.llvm.org/D121727
More information about the llvm-commits
mailing list