[PATCH] D121830: [memprof] Update the frame is inline logic and unittests.

Fri Mar 18 13:38:03 PDT 2022

snehasish added a comment.

In D121830#3387825 <https://reviews.llvm.org/D121830#3387825>, @tejohnson wrote:

> lgtm
>
> Unfortunately the ordering is not documented on the DIInliningInfo class. And confusingly, one piece of code sets an Inlined flag by the check "I > 0" (https://github.com/llvm/llvm-project/blob/49c048add4c980936fc2918838288ae2d795587d/llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp#L198).
> However, if I look at how that flag is used, it is used to print "(inlined by)" *before* the current frame's function name, so it seems to apply to the I-1 frame, which actually means that all but the last frame are inlined - consistent with the change you have made here. Consider making a separate NFC change to add a comment to DIInliningInfo?

Sent https://reviews.llvm.org/D122033 to add a comment to getFrame(). Thanks for taking the time to examine existing usage to double check!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121830/new/

https://reviews.llvm.org/D121830