[PATCH] D121972: Add cmake/ to release tarballs via concatenation
Aaron Puchert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 18 13:16:03 PDT 2022
aaronpuchert added a comment.
In D121972#3393048 <https://reviews.llvm.org/D121972#3393048>, @Ericson2314 wrote:
> if a two directory tarbomb is no good, we can add another layer of nesting?
I suggested a separate tarball <https://github.com/llvm/llvm-project/issues/53281#issuecomment-1052666213> for `cmake/`, but @kwk had the idea to pack it along with the existing projects (D118481 <https://reviews.llvm.org/D118481>) which would make it work transparently.
That is, if you have a pre-14 build script that unpacks the tarball, then switches into e.g. `llvm-$version.src/` and starts CMake there, it should also work with this, because the top-level CMake folder is in `../cmake`. Even if you add subprojects into e.g. `llvm/tools`, they should also find these files, because a copy comes with their own tarball.
If we nest this, existing build scripts will certainly have to be changed. Then I think we better just provide a separate copy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121972/new/
https://reviews.llvm.org/D121972
More information about the llvm-commits
mailing list